Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed warnings using flutter v3 #1640

Merged
merged 6 commits into from May 18, 2022
Merged

fix: Removed warnings using flutter v3 #1640

merged 6 commits into from May 18, 2022

Conversation

karvulf
Copy link
Contributor

@karvulf karvulf commented May 18, 2022 •
edited

Description

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

#1638

@karvulf karvulf changed the title removed warnings Fix: Removed warnings using flutter v3 May 18, 2022
@karvulf karvulf changed the title Fix: Removed warnings using flutter v3 fix: Removed warnings using flutter v3 May 18, 2022
@spydon
Copy link
Member

spydon commented May 18, 2022

Since the minimum version specified for Flame is 2.10.0 we can't remove the ! just yet.

@karvulf
Copy link
Contributor Author

karvulf commented May 18, 2022 •
edited

Hi @spydon thank you for your response.
I added another approach to get rid of this warning. You can also see the official documentation of flutter: https://docs.flutter.dev/development/tools/sdk/release-notes/release-notes-3.0.0

spydon
spydon approved these changes May 18, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just run flutter/melos format.
And the TODO should not be part of the dartdoc.

spydon
spydon reviewed May 18, 2022
View reviewed changes
packages/flame/lib/src/game/game_render_box.dart Outdated Show resolved Hide resolved
packages/flame_audio/lib/bgm.dart Outdated Show resolved Hide resolved
@spydon spydon merged commit 6921482 into flame-engine:main May 18, 2022
@karvulf karvulf deleted the feature/flutter-upgrade-to-v3 branch May 19, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@karvulf @spydon @erickzanardo @Desudar