Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Use navx for PointToTarget #92

Closed
wants to merge 2 commits into from
Closed

Use navx for PointToTarget #92

wants to merge 2 commits into from

Conversation

rutmanz
Copy link
Member

@rutmanz rutmanz commented Mar 3, 2022

resolves #70

@natesales natesales mentioned this pull request Mar 3, 2022
Open
@natesales
Copy link
Contributor

#73 will conflict. Let's wait to test #73 first to ensure the MedianFilter is an appropriate choice for preprocessing and then merge it in here.

@knightss27
Copy link
Contributor

Admittedly this probably removes some need for the median filter, but I'm interested to see how the filter works on the robot first.

@knightss27
Copy link
Contributor

Also does this actually not check the limelight until it's done turning? Looks like it just turns based on the navX but is still checking the limelight to see if it's done, which I'm not sure it make sense to do until your navX has turned the original amount you wanted.

@knightss27 knightss27 mentioned this pull request Mar 7, 2022
Merged
@knightss27 knightss27 closed this Mar 7, 2022
@rutmanz rutmanz deleted the zach/targeting-navx branch March 8, 2022 00:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@natesales natesales natesales approved these changes

@knightss27 knightss27 Awaiting requested review from knightss27

@sanashah007 sanashah007 Awaiting requested review from sanashah007 sanashah007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Limelight pose usage with check at end of turn
3 participants
@rutmanz @natesales @knightss27