[OpenMP] miscellaneous parse tree fix #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix `aligned(argument-list[ : alignment])` for `declare simd`
tskeith
reviewed
Aug 20, 2019
lib/semantics/check-omp-structure.cc
Outdated
| OmpClauseSet allowed{OmpClause::LINEAR, OmpClause::ALIGNED, | ||
| OmpClause::UNIFORM, OmpClause::INBRANCH, OmpClause::NOTINBRANCH}; | ||
| SetContextAllowed(allowed); | ||
| SetContextAllowedOnce(OmpClauseSet{OmpClause::SIMDLEN}); |
There was a problem hiding this comment.
This line could just be:
SetContextAllowedOnce({OmpClause::SIMDLEN});
tskeith
approved these changes
Aug 20, 2019
peterwaller-arm
pushed a commit
to peterwaller-arm/f18
that referenced
this pull request
Dec 5, 2019
Fix `aligned(argument-list[ : alignment])` for `declare simd` (original implementation will throw parser error if `: alignment` is present.
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
Fix `aligned(argument-list[ : alignment])` for `declare simd` (original implementation will throw parser error if `: alignment` is present. Original-commit: flang-compiler/f18@f3f50f9 Reviewed-on: flang-compiler/f18#669
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
Fix `aligned(argument-list[ : alignment])` for `declare simd` (original implementation will throw parser error if `: alignment` is present. Original-commit: flang-compiler/f18@f3f50f9 Reviewed-on: flang-compiler/f18#669
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happen to see the bug for
alignedclause.Fix
aligned(argument-list[ : alignment])fordeclare simd.