Fix clang build on MacOS #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang doesn't consider `std::strlen` of a constant to be a constexpr, so just replace with the actual length.
klausler
approved these changes
Sep 25, 2019
| @@ -43,7 +43,7 @@ using namespace parser::literals; | |||
| struct ModHeader { | |||
| static constexpr const char *bom{"\xef\xbb\xbf"}; | |||
| static constexpr const char *magic{"!mod$ v1 sum:"}; | |||
| static constexpr int magicLen{std::strlen(magic)}; | |||
| static constexpr int magicLen{13}; | |||
There was a problem hiding this comment.
Even better, declare bom and magic as arrays, use sizeof, and subtract one for the NUL.
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
clang doesn't consider `std::strlen` of a constant to be a constexpr, so just replace with the actual length. Original-commit: flang-compiler/f18@738deab Reviewed-on: flang-compiler/f18#761
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/tsk-modfiles Fix clang build on MacOS Original-commit: flang-compiler/f18@b99d166 Reviewed-on: flang-compiler/f18#761
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
clang doesn't consider `std::strlen` of a constant to be a constexpr, so just replace with the actual length. Original-commit: flang-compiler/f18@738deab Reviewed-on: flang-compiler/f18#761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clang doesn't consider
std::strlenof a constant to be a constexpr,so just replace with the actual length.