Move checks for valid array-spec to check-declarations.cc #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time we finish processing an array-spec in `resolve-names.cc`, we don't know if the entity is going to be declared ALLOCATABLE later so we can't check for validity there. In the new test in `resolve58.f90` (based on issue #930) we were reporting an error on `b` and not on `a` when it should be the reverse. The fix is to move array-spec checking to `check-declarations.cc`, after name resolution is complete. Fixes #930.
klausler
approved these changes
Jan 14, 2020
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
At the time we finish processing an array-spec in `resolve-names.cc`, we don't know if the entity is going to be declared ALLOCATABLE later so we can't check for validity there. In the new test in `resolve58.f90` (based on issue flang-compiler/f18#930) we were reporting an error on `b` and not on `a` when it should be the reverse. The fix is to move array-spec checking to `check-declarations.cc`, after name resolution is complete. Fixes flang-compiler/f18#930. Original-commit: flang-compiler/f18@c596d2f Reviewed-on: flang-compiler/f18#933
swift-ci
pushed a commit
to apple/llvm-project
that referenced
this pull request
Apr 9, 2020
…/tsk-issues Move checks for valid array-spec to check-declarations.cc Original-commit: flang-compiler/f18@7cf6f61 Reviewed-on: flang-compiler/f18#933
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this pull request
Oct 7, 2022
At the time we finish processing an array-spec in `resolve-names.cc`, we don't know if the entity is going to be declared ALLOCATABLE later so we can't check for validity there. In the new test in `resolve58.f90` (based on issue flang-compiler/f18#930) we were reporting an error on `b` and not on `a` when it should be the reverse. The fix is to move array-spec checking to `check-declarations.cc`, after name resolution is complete. Fixes flang-compiler/f18#930. Original-commit: flang-compiler/f18@c596d2f Reviewed-on: flang-compiler/f18#933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time we finish processing an array-spec in
resolve-names.cc,we don't know if the entity is going to be declared ALLOCATABLE later
so we can't check for validity there. In the new test in
resolve58.f90(based on issue #930) we were reporting an error on
band not onawhen it should be the reverse.
The fix is to move array-spec checking to
check-declarations.cc,after name resolution is complete.
Fixes #930.