Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flangrti: libnuma stubs exported by Flang runtime library #653

Closed
pawosm-arm opened this issue Jan 9, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@pawosm-arm
Copy link
Contributor

commented Jan 9, 2019

flangrti part of Flang runtime library contains numa.c file full of libnuma functions stubs. This results in potential link-time problem for those who link against real libnuma. Since flang frontend does not seem to emit calls to those functions, I'd suggest to remove them (along with whole numa.c file) from the project.

@sscalpone

This comment has been minimized.

Copy link
Contributor

commented Jan 9, 2019

Including numa.c in the flang library is wrong. We'll remove it soon.

@benbenolson

This comment has been minimized.

Copy link

commented Jan 10, 2019

I've been hunting this bug down for several days. I had no idea why all of my code no longer works in Fortran applications. This needs to be removed ASAP, as it quietly breaks any code that links against libflang. Why don't you just link libflang against actual libnuma?

gklimowicz added a commit to ThePortlandGroup/flang-stage that referenced this issue Jun 18, 2019

@sscalpone sscalpone closed this in 1c2d68b Jun 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.