patch flang runtime library #980
Conversation
runtime/flang/curdir.c
Outdated
| @@ -102,5 +104,8 @@ void __fort_gethostname(host) char *host; | |||
| } | |||
| p = un.nodename; | |||
| } | |||
| #else | |||
| strcpy(p, "localhost"); | |||
There was a problem hiding this comment.
There should be an equivalent for gethostname in the Win32 or Winsock API, right?
Can you keep the support for -curhost on Windows?
There was a problem hiding this comment.
There is, but I haven't put it in yet.
There was a problem hiding this comment.
that should be good for now; I will add support for this later.
There was a problem hiding this comment.
Will add TODO in a separate patch.
|
@kaadam Are you going to look at this? |
xoviat
requested review from
kiranchandramohan,
michalpasztamobica and
shivaramaarao
|
Could you squash those 18 commits into one? |
|
@pawosm-arm do I need feedback from shivaramaarao first? Or do you have write access? |
|
@shivaramaarao has to approve for the x86_64/amd64 platform. @pawosm-arm, @bryanpkc or myself can approve for aarch64. |
|
I'll wait until he approves, then squash them. |
* modify function so that they work on windows. * add OMP alias to forward fortran OMP calls to c library
xoviat
force-pushed
the
windows-working-2
branch
from
d9ac7ec to
06feecf
Compare
|
@bryanpkc @shivaramaarao @kiranchandramohan Could you please take a look at this PR? Thanks in advance! |
|
@kiranchandramohan is there any chance that this will be merged soon? |
|
I will run a few tests tomorrow and if OK will accept. Does @bryanpkc have further comments? |
|
As per the new pull request policy, we only need 2 reviewers (1 windows + 1 other) to review and approve windows PRs. This patch meets the criteria and hence can be merged if the CI is passing. Thanks @xoviat for working on this patch. https://github.com/flang-compiler/flang/wiki/Community#the-pull-request-process |
|
Sorry I missed the messages on this PR. Thanks for merging @kiranchandramohan. |
|
@xoviat For future reference please following the coding convention and use 2-space indents. |
patch the runtime library so that it works on windows.