Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start a Discussion Tag Popup closes in IE 11 #1504

Open
D-mata opened this issue Jul 11, 2018 · 12 comments
Open

Start a Discussion Tag Popup closes in IE 11 #1504

D-mata opened this issue Jul 11, 2018 · 12 comments
Labels

Comments

@D-mata
Copy link
Contributor

@D-mata D-mata commented Jul 11, 2018

When creating a new discussion using "Start a Discussion", the modal that appears if a tag is not chosen closes immediately after it appears and leaves the default overlay.

Steps to Reproduce

  1. Go to 'Start a Discussion'
  2. Fill out Title and Post text
  3. Then click "Post Discussion"
  4. See the popup appear then fade away
@franzliedke

This comment has been minimized.

Copy link
Member

@franzliedke franzliedke commented Jul 12, 2018

Can anybody reproduce this?

@D-mata Do you see any error messages in the browser's console?

@ardacebi

This comment has been minimized.

Copy link
Contributor

@ardacebi ardacebi commented Jul 15, 2018

I tested on IE 9, and it works fine. Not sure about IE 11.

ezgif-4-a352cfbd77

Environment
http://104.251.211.123 (Beta 7)

@D-mata

This comment has been minimized.

Copy link
Contributor Author

@D-mata D-mata commented Jul 20, 2018

flarum-ie11-issue

There are no errors in the console window, and none in network calls.

@ardacebi

This comment has been minimized.

Copy link
Contributor

@ardacebi ardacebi commented Jul 20, 2018

https://www.browserling.com/browse/win/7/ie/11/http%3A%2F%2Fdiscuss.flarum.org

I tried here and I see the exact same output @D-mata is getting. Try it yourself. (Confirming)

Apologies for the previous reply, I deleted it.


If anyone of you did notice, the search bar and the buttons are actually there, you can click and select them, even perform a search. The problem is their visibility.

@franzliedke franzliedke removed the Frontend label Jul 21, 2018
@ardacebi

This comment has been minimized.

Copy link
Contributor

@ardacebi ardacebi commented Jul 30, 2018

I tried here and I see the exact same output @D-mata is getting. Try it yourself. (Confirming)

Just to make things right, I confirmed this and experiencing the same @D-mata sent on his GIF. Can we remove the needs confirmation label?

@D-mata

This comment has been minimized.

Copy link
Contributor Author

@D-mata D-mata commented Sep 19, 2018

So it appears to be this line in the Modal section of forum.js.map and admin.js.map that doesnt work in IE11:

 .one('bsTransitionEnd', function ()
           that.$element.trigger('focus').trigger(e)

Removing the command doesn't seem to affect anything. I may try to submit the code change later today to see if that line of code is needed.

@tankerkiller125

This comment has been minimized.

Copy link
Contributor

@tankerkiller125 tankerkiller125 commented Jan 20, 2020

It appears that as of beta11.1 discuss no longer functions at all on IE11 (nightly and beta are fine), what is interesting is that my forum that has polyfill.io enabled (added myself) everything works completely as expected including the modules despite having about the same extensions as discuss.

@ghost

This comment has been minimized.

Copy link

@ghost ghost commented Jan 20, 2020

Temporary Solution

I faced the same issue on Discuss and on my own forum. No idea why this is happening. I cleared the cache and browser data on my browser (not sure if clearing cache alone is sufficient) and it seems to have fixed the issue for now...

@franzliedke

This comment has been minimized.

Copy link
Member

@franzliedke franzliedke commented Jan 31, 2020

@tankerkiller125 What about https://nightly.flarum.site/ and https://beta.flarum.site/? Maybe the problem is one of the many extensions enabled on Discuss...

@tankerkiller125

This comment has been minimized.

Copy link
Contributor

@tankerkiller125 tankerkiller125 commented Jan 31, 2020

@franzliedke On nightly and beta the tags disappearing still happen, but the overall the site loads. Proxying in Polyfill.io resolves the tags dialog disappearing but I'm not sure why that is since we don't get any console errors. What's interesting is that the dialog is still technically speaking open and you can technically add tags if have an idea of where tags are located and press the enter button, it seems like a potential shadow DOM issue.

@datitisev

This comment has been minimized.

Copy link
Member

@datitisev datitisev commented Jan 31, 2020

This doesn't just occur on IE, it sometimes happens on Chrome and Firefox, among others, with the same behavior @tankerkiller125 describes.

@matteocontrini

This comment has been minimized.

Copy link
Contributor

@matteocontrini matteocontrini commented Jan 31, 2020

Isn't this the same issue as #1813?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.