Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline mode doesn't allow access to administrators in beta 8 #1732

Open
matteocontrini opened this issue Jan 21, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@matteocontrini
Copy link

commented Jan 21, 2019

Bug Report

Current Behavior
Enabling offline mode in config.php disallows access to already logged-in administrators. In beta 7, the administrators were allowed to access the /admin area.

Steps to Reproduce

  1. Open a forum that is on beta 8 and where you have access to an administrator account
  2. Make sure you're logged in as an adminsitrator
  3. Set the key offline to the value of true in the config.php file
  4. Open the forum again in the browser and see the maintenance message on both / and /admin

Expected Behavior
The administrator should be able to see at least the administration area, as it was in beta 7, according to #459.

Screenshots
immagine

Environment

  • Flarum version: 0.1.0-beta.8.1.
  • PHP version: 7.2.12

@luceos luceos added the type/bug label Jan 21, 2019

@MichaelBelgium

This comment has been minimized.

Copy link

commented Jan 21, 2019

Mhm suggestion;

already logged-in administrators

So u have to login before putting it "offline" ? Can't we improve that, like the way laravel does? php artisan down [--message] [--allow]

If there would be a command php flarum down and php flarum up, wouldn't that be a nice addtion?

@franzliedke

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

Let's stick to fixing the regression in this issue, and keep feature discussion in #459.

If there even is a regression one: I faintly remember that some part of maintenance mode was removed on purpose in the past. @tobscure Do you remember?

@luceos luceos referenced a pull request that will close this issue Feb 12, 2019

Open

Allowing access to admin area when Flarum is offline (maintenance) #1749

0 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.