New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching title within discussions from search bar #1738

Open
bdumaspilhou opened this Issue Jan 29, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@bdumaspilhou
Copy link

bdumaspilhou commented Jan 29, 2019

Bug Report

Current Behavior
I have 2 discussions and when I'm searching them with a word from searchbar, no result.

Expected Behavior
I don't understand as last version of Flarum added this point [Improve search performance and design (#1339, 7e95b80)]

Screenshots
Discussions List
image

After search
image

Environment

  • Flarum version: 0.1.0-beta.8.1
  • Webserver: Apache 2.37
  • Hosting environment: vps
  • PHP version: 7.3.1-1
  • MySQL 5.7.19
Output of "php flarum info", run this in terminal in your Flarum directory.

image

Many Thanks

@bdumaspilhou

This comment has been minimized.

Copy link
Author

bdumaspilhou commented Jan 31, 2019

Hi All,
I found the problem and I correct it on my local sources.
The problem was in core/src/Discussion/search/Gambit/FulltextGambit.php on line 55. Replace ->join by ->leftJoin to correct this.

@luceos

This comment has been minimized.

Copy link
Member

luceos commented Feb 1, 2019

@bdumaspilhou could you perhaps send in a PR to mitigate this and we can review?

Editing files in your vendor folder will block upgrades.

bdumaspilhou pushed a commit to bdumaspilhou/core that referenced this issue Feb 1, 2019

@bdumaspilhou bdumaspilhou referenced a pull request that will close this issue Feb 1, 2019

Open

Fixes #1738 : Search Title within discussions #1741

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment