Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mail: Handle incomplete email configuration #1763

Closed
franzliedke opened this issue Mar 22, 2019 · 4 comments
Closed

Mail: Handle incomplete email configuration #1763

franzliedke opened this issue Mar 22, 2019 · 4 comments
Assignees
Labels
Milestone

Comments

@franzliedke
Copy link
Member

@franzliedke franzliedke commented Mar 22, 2019

Continues #1169

  • Show a warning message when a driver is selected but not fully configured (i.e. missing values for required fields).
  • Fall back to a NullDriver that does not send any mails when that is the case.

This needs an extension to the DriverInterface - something along the lines of getRequiredFields() or, more flexibly, isFullyConfigured($settings).

Open question:
Do we want to allow selecting the "log" driver explicitly? What's the value in that?

@luceos

This comment has been minimized.

Copy link
Member

@luceos luceos commented Mar 22, 2019

What if we allow the log driver only when debug is on? I can't see why the log driver would be useful in production environment really..

@franzliedke

This comment has been minimized.

Copy link
Member Author

@franzliedke franzliedke commented Mar 23, 2019

What if we allow the log driver only when debug is on?

Do you mean allow selecting it in the dropdown? Or enable automatically when logging in?

I almost tend towards never listing it in the dropdown, and simply using it automatically when settings are not complete for any of the other drivers.

@tobyzerner

This comment has been minimized.

Copy link
Contributor

@tobyzerner tobyzerner commented Mar 24, 2019

I don't think we should fall back to the log driver automatically, because if someone hasn't configured their mail settings correctly it doesn't necessarily mean they want emails to go to a log file. If a driver isn't configured correctly, just don't send mail.

I think we should allow selecting the log driver explicitly in any environment to keep things simple.

@franzliedke franzliedke changed the title Mail: Fall back to log driver / show warning Mail: Handle incomplete email configuration Mar 24, 2019
@franzliedke

This comment has been minimized.

Copy link
Member Author

@franzliedke franzliedke commented Mar 24, 2019

Fair enough. I've updated the issue and TODO list accordingly.

@Ralkage Ralkage modified the milestones: 0.1.0-beta.10, 0.1.0-beta.11 Sep 10, 2019
@franzliedke franzliedke removed their assignment Sep 27, 2019
franzliedke added a commit to flarum/lang-english that referenced this issue Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.