Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font-awesome version 5.9.5 fa-*.less #1790

Closed
Tall75 opened this issue Jun 8, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@Tall75
Copy link

commented Jun 8, 2019

Bug Report

Current Behavior
composer updates which update font-awsome to version 5.9.5 missing fa-icons

Font Awesome 5.9.0 LESS naming change https://fontawesome.com/how-to-use/on-the-web/using-with/less
Font Awesome 5.0.13 https://fontawesome.com/v5.0.13/how-to-use/on-the-web/using-with/less

Steps to Reproduce

  • Go to Bazaar in admin console
  • Install FoF Profile Image Crop 0.1.1

On command line

  • ls -ltr vendor/components/font-awesome/less from flarum root folder, see that fa-files are missing
  • php flarum cache:clear

Expected Behavior
Forum is not working anymore

In ./storage/logfile:
production.ERROR: Less_Exception_Parser: File fa-brands.less not found. in variables.less in /flarum/vendor/oyejorge/less.php/lib/Less/Parser.php:2793

Screenshots

Environment

  • Flarum version: Flarum core 0.1.0-beta.8.1
Output of "php flarum info", run this in terminal in your Flarum directory.

Possible Solution

Check this discussion and the given workaround by Intern

https://discuss.flarum.org/d/20282-less-exception-parser-file-fa-brands-less-not-found-in-variables-less/11

Additional Context
Add any other context about the problem here.

@luceos

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

#1791 fixes this, this breaks ALL new installations and upgrades with composer update where components/font-awesome is updated to 5.9.0 or higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.