Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal is not showing #1813

Open
luceos opened this issue Jul 10, 2019 · 14 comments
Open

Modal is not showing #1813

luceos opened this issue Jul 10, 2019 · 14 comments
Labels

Comments

@luceos
Copy link
Member

@luceos luceos commented Jul 10, 2019

Bug Report

Current Behavior

Whenever you open the edit tags modal, it hides itself. This is caused by the missing class in. This makes editing tags a pain.

Steps to Reproduce

  1. Go to discuss.flarum.org, open a discussion
  2. Click on edit tags
  3. Modal hides

The behavior is sporadic, but just now it happened to me constantly on discuss using firefox.

@luceos luceos added the type/bug label Jul 10, 2019
@luceos

This comment has been minimized.

Copy link
Member Author

@luceos luceos commented Sep 25, 2019

Happened to me again, marked all notifications as read. Refreshed page, nothing.

Can someone try to reproduce on firefox: https://discuss.flarum.org/d/21396-solved-twitter-login-shows-the-page-you-requested-could-not-be-found/16

@VanillaScent

This comment has been minimized.

Copy link

@VanillaScent VanillaScent commented Sep 27, 2019

Can confirm luceos, I am using the keyboard shortcut extension as you saw and the modal is not showing either.
I seem to be using firefox too. Using any crhome variant it does work.
So this seems to be a firefox related issue.

note: I didn't reproduce on twitter login, but on kvothe/keyboard-shortcuts which is a fork by kvothe.

@luceos

This comment has been minimized.

Copy link
Member Author

@luceos luceos commented Sep 27, 2019

@VanillaScent does it happen without the keyboard shortcuts extension as well? We don't have that one on discuss. If so, please post your flarum info output.

@VanillaScent

This comment has been minimized.

Copy link

@VanillaScent VanillaScent commented Sep 27, 2019

No only seems to happen with keyboard shortcuts. I haven't seen this issue in editing tags on firefox. The tags modal has showed up fine for me since the start. it does seem to be the same issue though as the modal from keyboard shortcuts doesnt show up in firefox.

So perhaps its unrelated, but it might not be as it only occurs in firefox.

@GameBurrow

This comment has been minimized.

Copy link

@GameBurrow GameBurrow commented Sep 30, 2019

As I posted here: https://discuss.flarum.org/d/21503-tags-edit-overlay-opens-and-immediately-dissapears

I have this issue with one of the chromium based browsers Vivaldi 2.7.1628.33 (Stable channel) (64-bit).

I didn't have this issue with the same browser in August, I've updated flarum and replaced deprected extensions in the time between. It happens both on discuss.flarum.org and on my own flarum installation.

@datitisev

This comment has been minimized.

Copy link
Member

@datitisev datitisev commented Oct 1, 2019

Looks like this was reported last year, see #1504. 🤔

@GameBurrow

This comment has been minimized.

Copy link

@GameBurrow GameBurrow commented Oct 2, 2019

For me, this issue is new. Last time I actually tried this function (flarum was in beta.9 then) and then I didn't have the issue.

@taciturasa

This comment has been minimized.

Copy link

@taciturasa taciturasa commented Oct 26, 2019

Currently having this issue still on my forum. Using Firefox as well. Here is a gif.

https://cdn.discordapp.com/attachments/369174406909394944/637787236749934623/whyisthishappening.gif

It's not sporadic at all for me unfortunately. It happens nearly every time, with it only staying with some combination of typing or clicking. This completely breaks the forum for Firefox users.

I have also encountered this on SEO.

@matteocontrini

This comment has been minimized.

Copy link
Contributor

@matteocontrini matteocontrini commented Oct 28, 2019

It started to happen to me as well, with Firefox and only on one discussion for some reason 🤔

EDIT: ok it's not just one, but it's not all either

@tiuram0n

This comment has been minimized.

Copy link

@tiuram0n tiuram0n commented Nov 5, 2019

I am also having problems with Google chrome.

Version: 78.0.3904.87
SO: Windows 10 OS Version 1903

@luceos

This comment has been minimized.

Copy link
Member Author

@luceos luceos commented Nov 11, 2019

People involved, also mention whether you use an adblocker and virus software.

@matteocontrini

This comment has been minimized.

Copy link
Contributor

@matteocontrini matteocontrini commented Nov 11, 2019

I use Firefox 70 built-in tracking protection, but no ad blocking (I have AdGuard for Firefox in opt-in mode, but it's not enabled on my forum).

@luceos

This comment has been minimized.

Copy link
Member Author

@luceos luceos commented Nov 11, 2019

I also use AdGuard and it is enabled for me on discuss.

@matteocontrini

This comment has been minimized.

Copy link
Contributor

@matteocontrini matteocontrini commented Nov 23, 2019

@luceos this has just happened to me again and I tried disabling both Firefox's tracking protection and the AdGuard extension, but the problem is still there, so it's probably unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.