New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search engine optimization #189

Open
tobscure opened this Issue Jul 28, 2015 · 12 comments

Comments

Projects
None yet
7 participants
@tobscure
Member

tobscure commented Jul 28, 2015

Flarum renders very basic versions of the discussion list and discussions (within <noscript> tags), which are going to be specifically optimised for search engines. This all takes place in Flarum\Forum\IndexAction and DiscussionAction, which extend Support\ClientAction and use Flarum\Support\ClientView. The actions get data from the Flarum's API and pass it onto content views (discussion.blade.php and index.blade.php). I'm happy to explain more if need be because it can get pretty confusing.

Put simply, the code is a mess. It needs to be rethought and refactored. A few thoughts:

  • We probably want to use or build some kind of library that makes it easier to work with a JSON-API document payload.
  • Similarly, we probably want to use or build some kind of library that will help generate URLs/query strings/etc.

Only after doing this will we be able to effectively optimise the SEO content and do the following:

This was referenced Jul 28, 2015

Closed
@axisdos

This comment has been minimized.

Show comment
Hide comment
@axisdos

axisdos Jul 28, 2015

Noindex for subpages (Inspired by Yoast SEO for WordPress) to avoid duplicate content. and URL Friendly.

axisdos commented Jul 28, 2015

Noindex for subpages (Inspired by Yoast SEO for WordPress) to avoid duplicate content. and URL Friendly.

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Jul 28, 2015

Member

@axisdos Noindex isn't needed when we have the rel=canonical tag. :)

Member

franzliedke commented Jul 28, 2015

@axisdos Noindex isn't needed when we have the rel=canonical tag. :)

@dcsjapan

This comment has been minimized.

Show comment
Hide comment
@dcsjapan

dcsjapan Jul 28, 2015

Member

Questions of how to handle foreign language/unicode URLs -- such as #194 -- will also have SEO implications. In that regard, unfortunately, I think different regions may prefer different solutions.

Member

dcsjapan commented Jul 28, 2015

Questions of how to handle foreign language/unicode URLs -- such as #194 -- will also have SEO implications. In that regard, unfortunately, I think different regions may prefer different solutions.

@tobscure tobscure modified the milestone: 1.0 Beta 1 Jul 30, 2015

@neandrake

This comment has been minimized.

Show comment
Hide comment
@neandrake

neandrake Aug 4, 2015

Would this tie into Accessibility at all? I'm not extremely familiar with it, but when structuring the noscript HTML along with the rest of the page, it would be nice if parts of it were identifiable for users with disabilities.

http://www.w3.org/WAI/intro/aria

neandrake commented Aug 4, 2015

Would this tie into Accessibility at all? I'm not extremely familiar with it, but when structuring the noscript HTML along with the rest of the page, it would be nice if parts of it were identifiable for users with disabilities.

http://www.w3.org/WAI/intro/aria

@tobscure tobscure removed this from the 1.0 Beta 1 milestone Aug 6, 2015

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Aug 7, 2015

Member

Could this approach be an alternative to the noscript tags?

Member

franzliedke commented Aug 7, 2015

Could this approach be an alternative to the noscript tags?

@tobscure

This comment has been minimized.

Show comment
Hide comment
@tobscure

tobscure Aug 7, 2015

Member

Quite possibly, feels a little bit hacky though? I'm not too fussed

Member

tobscure commented Aug 7, 2015

Quite possibly, feels a little bit hacky though? I'm not too fussed

@tobscure tobscure referenced this issue Aug 28, 2015

Closed

v0.1.0 roadmap (old) #74

19 of 53 tasks complete

@justjavac justjavac referenced this issue Sep 7, 2015

Open

Flarum v0.1.0 开发路线图 #3

18 of 53 tasks complete

@tobscure tobscure referenced this issue Sep 7, 2015

Closed

SEO URLs Faulty #433

@tobscure tobscure added the Backend label Sep 16, 2015

tobscure added a commit that referenced this issue Oct 21, 2015

Translate basic HTML views
app('view') call to set translator is temporary. See #189
@dcsjapan

This comment has been minimized.

Show comment
Hide comment
@dcsjapan

dcsjapan Apr 1, 2016

Member

#906 is an SEO-related issue specific to the Tags extension.

(I hope I was right to file it as a separate issue.)

Member

dcsjapan commented Apr 1, 2016

#906 is an SEO-related issue specific to the Tags extension.

(I hope I was right to file it as a separate issue.)

@franzliedke franzliedke modified the milestone: 0.1.0 Apr 7, 2016

@01010000101001100

This comment has been minimized.

Show comment
Hide comment
@01010000101001100

01010000101001100 Jun 8, 2016

I investigated links on my Flarum and posted results in this topic on official Flarum forum, have a look:
https://discuss.flarum.org/d/3103-is-the-flarum-s-seo-seriously-messed-up-or-am-i-doing-something-wrong

01010000101001100 commented Jun 8, 2016

I investigated links on my Flarum and posted results in this topic on official Flarum forum, have a look:
https://discuss.flarum.org/d/3103-is-the-flarum-s-seo-seriously-messed-up-or-am-i-doing-something-wrong

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke May 12, 2017

Member

Also interesting, with regards to changing <title> and other meta tags when doing client-side navigation: http://searchengineland.com/tested-googlebot-crawls-javascript-heres-learned-220157

Member

franzliedke commented May 12, 2017

Also interesting, with regards to changing <title> and other meta tags when doing client-side navigation: http://searchengineland.com/tested-googlebot-crawls-javascript-heres-learned-220157

@tobscure tobscure removed this from the 0.1.0 milestone Jul 22, 2017

@gwillem

This comment has been minimized.

Show comment
Hide comment
@gwillem

gwillem Nov 23, 2017

Contributor

@01010000101001100 refers to a bug in the pagination code. Version 0.1.0-beta.7 will infinitely link to the "next" page id, even if there are no more discussions. I have only 1 page of discussions, but Google has already crawled to page 584. Fixing this would probably improve SEO a lot.

(--> #1310)

Contributor

gwillem commented Nov 23, 2017

@01010000101001100 refers to a bug in the pagination code. Version 0.1.0-beta.7 will infinitely link to the "next" page id, even if there are no more discussions. I have only 1 page of discussions, but Google has already crawled to page 584. Fixing this would probably improve SEO a lot.

(--> #1310)

@franzliedke franzliedke added the SEO label Dec 13, 2017

franzliedke added a commit that referenced this issue Jan 10, 2018

Only display pagination link if necessary
Otherwise, search engines start indexing pages that aren't filled yet.

Refs #189.
@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Jan 10, 2018

Member

@gwillem @01010000101001100 Thanks for the heads-up. I've fixed the incorrect generation of pagination links, along with some other minor pagination-related improvements.

Member

franzliedke commented Jan 10, 2018

@gwillem @01010000101001100 Thanks for the heads-up. I've fixed the incorrect generation of pagination links, along with some other minor pagination-related improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment