Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User's discussion page post excerpts added by flarum/sticky #2066

Open
datitisev opened this issue Mar 14, 2020 · 0 comments
Open

User's discussion page post excerpts added by flarum/sticky #2066

datitisev opened this issue Mar 14, 2020 · 0 comments

Comments

@datitisev
Copy link
Member

@datitisev datitisev commented Mar 14, 2020

When viewing a user's discussions (/u/<id>/discussions) the excerpts only appear when flarum/sticky is enabled - even though the code to show them is in core.

The following lines make this occur: https://github.com/flarum/sticky/blob/0a25c0cab7075ea708c244ad838e60782259dbda/js/src/forum/addStickyExcerpt.js#L7-L9

This should probably be in core as

  1. it doesn't just affect the main discussion page, to which flarum/sticky shows excerpts for sticky discussions, and
  2. it is not obvious to anybody that this extension is the one that adds it (myself included)

Thoughts? I spent a long time being confused, thinking my rewrite had broken something because the code for the excerpts was in but not showing anything. I only found it after debugging the HTTP requests and comparing them to those @ Flarum Discuss.

With Sticky:
img

Without Sticky:
img

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.