comment_count & discussion_count include hidden posts

[iPurpl3x]

Bug Report

Current Behavior
When a user has some posts or discussions that where hidden, the number of posts & discussions shown on his profile still includes the ones that where hidden.

Steps to Reproduce (as Admin)

1. Go to "All Discussions"
2. Click on "Start a discussion"
3. Fill in all needed content & post the discussion
4. Add a comment to the discussion
5. Go to Profile (using the Session Dropdown menu)
6. See number of Posts 2, Discussions 1
7. (so far all good)
8. Go the just created discussion
9. Hide the comment that was just added using the dotted menu
10. Now hide the discussion
11. Go to Profile (using the Session Dropdown menu)
12. See number of Posts 2, Discussions 1

Expected Behavior
At step (12.) there should be Posts 0, Discussions 0

Environment

• Flarum version: 0.1.0-beta.14-dev
• Website URL: https://nightly.flarum.site
• PHP version: 7.3.11
• Browser: Chrome 84

---

This issue was originally detected by @clarkwinkelmann and mentioned in #2227

[clarkwinkelmann]

We probably need to decide internally whether we want to make the change. It's not really a bug report as the current expected behavior is the one described.

I do think it would make sense to use a similar approach for posts as we do for discussion count, which would mean not counting private posts, posts in private discussions, deleted posts, and posts in deleted discussion.

That's a bit more complex to implement as discussion as the SQL query to update the number will quickly get more heavy.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[askvortsov1]

Closing as duplicate of https://github.com/flarum/core/issues/1006