New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: DB table name prefix #269

Closed
neo22s opened this Issue Aug 27, 2015 · 8 comments

Comments

Projects
None yet
3 participants
@neo22s

neo22s commented Aug 27, 2015

DB Usage of prefix on table names will make it lot easier to check which tables belong to flarum in case the client installs in an existing DB.

something like: flarum_config

What do you think?

ps: I wanted to post in the forum but for some reason I can not.

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Aug 28, 2015

Member

There's actually a setting for the prefix already. Thing is, it breaks the forum after installation ;)

I'll make this a priority for the next beta release.

Member

franzliedke commented Aug 28, 2015

There's actually a setting for the prefix already. Thing is, it breaks the forum after installation ;)

I'll make this a priority for the next beta release.

@franzliedke franzliedke added this to the 0.1.0-beta.2 milestone Aug 28, 2015

@tobscure tobscure referenced this issue Aug 28, 2015

Closed

v0.1.0 roadmap (old) #74

19 of 53 tasks complete
@neo22s

This comment has been minimized.

Show comment
Hide comment
@neo22s

neo22s Aug 28, 2015

I can also give some tips to improve performance on the DB structure level if you want ;) for example theres need to use a glob on the table settings? or more usage of myisam on many tables etc ;)

Great work guys. Regards!

neo22s commented Aug 28, 2015

I can also give some tips to improve performance on the DB structure level if you want ;) for example theres need to use a glob on the table settings? or more usage of myisam on many tables etc ;)

Great work guys. Regards!

franzliedke added a commit to flarum/flarum-ext-subscriptions that referenced this issue Aug 29, 2015

franzliedke added a commit to flarum/flarum-ext-sticky that referenced this issue Aug 29, 2015

franzliedke added a commit to flarum/flarum-ext-subscriptions that referenced this issue Aug 29, 2015

franzliedke added a commit to flarum/flarum-ext-tags that referenced this issue Aug 29, 2015

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Aug 29, 2015

Member

Considering this to be fixed - I optimized a whole bunch of raw query expressions to avoid them ignoring the database prefix. I'll keep testing with database prefix on my local install, so I'll hopefully come across any further errors.

Member

franzliedke commented Aug 29, 2015

Considering this to be fixed - I optimized a whole bunch of raw query expressions to avoid them ignoring the database prefix. I'll keep testing with database prefix on my local install, so I'll hopefully come across any further errors.

@tobscure

This comment has been minimized.

Show comment
Hide comment
@tobscure
Member

tobscure commented Aug 29, 2015

:D

@tobscure

This comment has been minimized.

Show comment
Hide comment
@tobscure

tobscure Aug 31, 2015

Member

@franzliedke Do we want to have a field for it in the installer though?

Member

tobscure commented Aug 31, 2015

@franzliedke Do we want to have a field for it in the installer though?

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Aug 31, 2015

Member

The web installer? Yeah, good point, I'll make a note to add it - it's already in the console version...

Member

franzliedke commented Aug 31, 2015

The web installer? Yeah, good point, I'll make a note to add it - it's already in the console version...

@neo22s

This comment has been minimized.

Show comment
Hide comment
@neo22s

neo22s Aug 31, 2015

In the web installer is good to have an optional input table prefix ;)

Also to review all permissions hosting compatibility etc... you can take a look at https://github.com/open-classifieds/openclassifieds2/tree/master/install

We also have a 1 file installer:
https://github.com/open-classifieds/openclassifieds2/blob/master/install-openclassifieds.php

hope this helps we worked hard during years to improve this and cover many many scenarios

neo22s commented Aug 31, 2015

In the web installer is good to have an optional input table prefix ;)

Also to review all permissions hosting compatibility etc... you can take a look at https://github.com/open-classifieds/openclassifieds2/tree/master/install

We also have a 1 file installer:
https://github.com/open-classifieds/openclassifieds2/blob/master/install-openclassifieds.php

hope this helps we worked hard during years to improve this and cover many many scenarios

franzliedke added a commit that referenced this issue Aug 31, 2015

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Aug 31, 2015

Member

Okay, I added the field to the web installer.

@neo22s Thanks for the links; I'll take a look at those when working on validation etc. :)

Member

franzliedke commented Aug 31, 2015

Okay, I added the field to the web installer.

@neo22s Thanks for the links; I'll take a look at those when working on validation etc. :)

@justjavac justjavac referenced this issue Sep 7, 2015

Open

Flarum v0.1.0 开发路线图 #3

18 of 53 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment