[Mentions] Add a contextual quote button when text is selected #320

Closed
tobscure opened this Issue Aug 29, 2015 · 5 comments

Comments

Projects
None yet
4 participants
@tobscure
Member

tobscure commented Aug 29, 2015

From @tobscure on May 22, 2015 3:26

Originally reported by amdad (http://demo.flarum.org/#/d/168/read-state-eager-load/6)

Small idea: maybe after select text to quote Reply button can show up to click somewhere on it? If post is long and we select just one of top line we don't need to scroll to bottom to click reply.

Copied from original issue: flarum/mentions#2

@tobscure

This comment has been minimized.

Show comment
Hide comment
@tobscure

tobscure Aug 29, 2015

Member

When post text is selected, we should show a "quote" button just above/below it. When clicked, a quote containing a post mention + the text will be added to the reply composer. (This is the same as what happens when you select text and hit the post's Reply button.)

What needs to be done:

  • Research how to detect what text is currently selected, get the post that contains it, and position an element next to it.
  • Implement.
Member

tobscure commented Aug 29, 2015

When post text is selected, we should show a "quote" button just above/below it. When clicked, a quote containing a post mention + the text will be added to the reply composer. (This is the same as what happens when you select text and hit the post's Reply button.)

What needs to be done:

  • Research how to detect what text is currently selected, get the post that contains it, and position an element next to it.
  • Implement.

@tobscure tobscure changed the title from Add a contextual quote button when text is selected to [Mentions] Add a contextual quote button when text is selected Aug 29, 2015

@tobscure tobscure added the Feature label Aug 29, 2015

@tobscure tobscure added this to the 0.1.0-beta.4 milestone Sep 4, 2015

@justjavac justjavac referenced this issue in justjavac/Flarum Sep 7, 2015

Open

Flarum v0.1.0 开发路线图 #3

18 of 53 tasks complete

@franzliedke franzliedke modified the milestones: 0.1.0-beta.5, 0.1.0-beta.6 Jan 7, 2016

@franzliedke

This comment has been minimized.

Show comment
Hide comment
@franzliedke

franzliedke Apr 10, 2016

Member

I know we want to be careful with more dependencies, but just in case it proves difficult, or we reimplement similar things in multiple places, there's this: https://popper.js.org/

Member

franzliedke commented Apr 10, 2016

I know we want to be careful with more dependencies, but just in case it proves difficult, or we reimplement similar things in multiple places, there's this: https://popper.js.org/

@jordanjay29

This comment has been minimized.

Show comment
Hide comment
@jordanjay29

jordanjay29 May 21, 2016

Member

Did anyone test Chrome compatibility? @modedeep on discuss.flarum (I replicated with Chromium on my own computer) can't quote emoticons/emoji with this feature.

Member

jordanjay29 commented May 21, 2016

Did anyone test Chrome compatibility? @modedeep on discuss.flarum (I replicated with Chromium on my own computer) can't quote emoticons/emoji with this feature.

@datitisev

This comment has been minimized.

Show comment
Hide comment
@datitisev

datitisev May 21, 2016

Member

@jordanjay29 I can't quote emoticons/emoji on Safari either... At least they aren't indispensable ;)

Member

datitisev commented May 21, 2016

@jordanjay29 I can't quote emoticons/emoji on Safari either... At least they aren't indispensable ;)

@jordanjay29

This comment has been minimized.

Show comment
Hide comment
@jordanjay29

jordanjay29 May 21, 2016

Member

Sounds like a webkit family bug.

Member

jordanjay29 commented May 21, 2016

Sounds like a webkit family bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment