Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1738 : Search Title within discussions #1741

Merged
merged 1 commit into from Mar 6, 2019

Conversation

@bdumaspilhou
Copy link
Contributor

commented Feb 1, 2019

**Fixes #1738 **

Changes proposed in this pull request:
You can search in title discussion even if word does not appear in a post of this discussion

Reviewers should focus on:
Test searching toolbar with a word in discussion title

@franzliedke franzliedke merged commit 33deea4 into flarum:master Mar 6, 2019
3 checks passed
3 checks passed
WIP Ready for review
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@franzliedke

This comment has been minimized.

Copy link
Member

commented Mar 6, 2019

Thanks a lot! Nice find and nice fix.

I've added a regression test to prevent this from coming back.

@bdumaspilhou

This comment has been minimized.

Copy link
Contributor Author

commented Mar 7, 2019

@Ralkage

This comment has been minimized.

Copy link
Member

commented Mar 10, 2019

SQL being my # 1, I should of caught this myself ;-)

@tobyzerner

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Any changes to the search engine should undergo performance testing before they are committed (or we should somehow automate that in the tests)

Unfortunately this change has a detrimental effect on performance in my rough testing - a search which previously took ~40ms now takes 3 seconds.

@franzliedke

This comment has been minimized.

Copy link
Member

commented Mar 24, 2019

Oh, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.