Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-add debug button/modal #1906

Merged
merged 2 commits into from Nov 9, 2019

Conversation

@pReya
Copy link
Contributor

pReya commented Oct 8, 2019

Fixes #1687

Changes proposed in this pull request:
Reintroduce the debug button in error modals, which was removed in 64686ef

Screenshot

Screenshot 2019-10-08 20 29 57

Confirmed

  • Frontend changes: tested on a local Flarum installation.

Required changes:
No tests or documentation changes needed (I guess?)

Fixes #1687
@datitisev

This comment has been minimized.

Copy link
Member

datitisev commented Oct 8, 2019

I think, even though we didn't include it in the issue comments, that we also wanted to log the error (console.error the URL, params (?), and response) so it can be viewed in the console after the error as well, and after the error message is dismissed.

I didn't look at your implementation, but is it basically the same as how it was before?

@pReya

This comment has been minimized.

Copy link
Contributor Author

pReya commented Oct 9, 2019

Yes, it is exactly the same old implementation – no code changes. I will take a look into the console debug output next week and update this PR accordingly.

Copy link
Member

datitisev left a comment

I fixed the alert dismission not working. This looks good to me, I may make a few further changes but those were not detailed in the issue.

@datitisev datitisev merged commit 54c5c09 into flarum:master Nov 9, 2019
11 of 19 checks passed
11 of 19 checks passed
PHP 7.1 / MySQL PHP 7.1 / MySQL
Details
PHP 7.1 / MySQL
Details
PHP 7.1 / MariaDB PHP 7.1 / MariaDB
Details
PHP 7.1 / MariaDB
Details
PHP 7.2 / MySQL PHP 7.2 / MySQL
Details
PHP 7.2 / MySQL
Details
PHP 7.2 / MariaDB PHP 7.2 / MariaDB
Details
PHP 7.2 / MariaDB
Details
PHP 7.3 / MySQL PHP 7.3 / MySQL
Details
PHP 7.3 / MySQL
Details
PHP 7.3 / MySQL (prefix) PHP 7.3 / MySQL (prefix)
Details
PHP 7.3 / MySQL (prefix)
Details
PHP 7.3 / MariaDB PHP 7.3 / MariaDB
Details
PHP 7.3 / MariaDB
Details
PHP 7.3 / MariaDB (prefix) PHP 7.3 / MariaDB (prefix)
Details
PHP 7.3 / MariaDB (prefix)
Details
WIP Ready for review
Details
continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/styleci/push The analysis has passed
Details
@pReya pReya deleted the pReya:ms/re-add-debug-button branch Nov 10, 2019
@luceos luceos modified the milestone: 0.1.0-beta.11 Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.