Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix Buggy Modals #2080
Changes proposed in this pull request:
First commit was proposing to change margin values for
Reviewers should focus on:
I know this one is hard to catch since it seems sporadic but try to test it with developer tools docked to bottom of the browser (make it bigger until you succeed).
Note that zooming out from the page before clicking on the "Choose Tags" button also fixes the issue (as stated by @sometao)
I look forward to your reviews and I need to fix this since it effects some of my modal related extensions.
datitisev left a comment
I tested this change locally, and it worked perfectly.
To reproduce, I had to open the developer tools and make them extremely tall. Not sure why the size of the available space causes issues with Bootstrap 3's modal plugin, but
Thanks for your effort!
This doesn't fix extension settings modal's issue.
Here are some quotes from @datitisev:
Some modal issues are still a mystery, i had the same missing class problem while developing the Diff extension and i end up adding it manually.
Maybe we should accept this PR as a solution for the tag selection modal issue (or we can just call it "a fix for double