Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing route for the flags page #23

Merged
merged 1 commit into from
May 20, 2020
Merged

Conversation

clarkwinkelmann
Copy link
Member

Just like notifications, flags have a page URL that's used only on mobile.

But unlike the notifications, the route was missing on the PHP side, so you end up in a 404 URL if you refresh the page on mobile while reading flags.

Tested locally.

Copy link
Sponsor Member

@askvortsov1 askvortsov1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@askvortsov1 askvortsov1 merged commit e47bec3 into master May 20, 2020
@askvortsov1 askvortsov1 deleted the cw/missing-route branch May 20, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants