Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract duplicated site setup to shared file #63

Merged
merged 1 commit into from Jan 31, 2020
Merged

Conversation

@franzliedke
Copy link
Member

franzliedke commented Jan 17, 2020

This extracts a common site.php file that sets up paths, as discussed in flarum/core#1669.

What this does not do (yet?):

  • Introduce a bootstrap directory to hold site.php and extend.php, as that would require further changes to existing app's skeleton, and I don't see the value in it to justify the effort.
  • Introduce any auto-detection to simplify switching to shared-hosts mode. The problem is that we would need to change both the paths in site.php (make public equal the base path), and the include in index.php. (The latter could be done at the expense of another stat call, but for site.php, I don't know.)

With this change, users switching to shared-hosts mode would still need to change/write two files. Not sure if that really is an improvement over the status quo.

@franzliedke

This comment has been minimized.

Copy link
Member Author

franzliedke commented Jan 18, 2020

Decision from today's meeting: We need to do more in this area, but we also want to move forward with this change.

@luceos
luceos approved these changes Jan 27, 2020
@franzliedke franzliedke merged commit 542331b into master Jan 31, 2020
1 check passed
1 check passed
WIP Ready for review
Details
@franzliedke franzliedke deleted the fl/1669-shared-hosts branch Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.