Fix new post injected above unread sticky #1868
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franzliedke
suggested changes
Sep 5, 2019
|
I had some issues on my end, but I was able to install pusher, from what I can see, it only works when a reply to an existing discussion is submitted, a new discussion does not trigger anything so I'd say the relevant code in the extension can be removed I have however restored the |
This comment has been minimized.
This comment has been minimized.
|
I'll review this in time for the upcoming beta.12. |
I can confirm that this fixes the issue, so unless there's code style problems we can probably merge this. |
askvortsov1
approved these changes
Mar 27, 2020
franzliedke
approved these changes
Apr 3, 2020
|
@SychO9 Congrats for getting your first PR merged! 🙌 And sorry it took so long. 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1751
Changes proposed in this pull request:
instead of prepending the new discussion to the list, this refreshes the list
Confirmed
Backend changes: tests are green (runphp vendor/bin/phpunit).