Improved UX by displaying hamburger instead of back arrow in mobile header on all pages #1999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eader on all pages As of right now, the mobile header displays a back arrow at the top right corner on some pages (specifically discussion pages). This adds no actual value to the user: - While on non-mobile devices hovering here would bring out the discussion list pane, this is not supported on mobile (and rightly so as it would add unnecessary complexity). - The only other hypothetical benefit of the back button on mobile is that the button brings the user to the homepage, as opposed to the browser's back button, which might close a window (if the page was opened via a link). However, the hamburger menu more than replaces this functionality: by convention, users know that clicking on the site logo/title in the slideout nav menu will bring them to the homepage (which it does). In summary, this change makes it much more convenient for users to access their account info/other navbar items, removes a somewhat redundant element, and does not diminish aesthetic.
Contributor
|
Hey, we're really close to our feature freeze for beta.12, so I will put this on our internal project board for beta.13. I want the team to have ample time to think about this. Thanks for the PR! ❤️ |
Member
Author
|
Absolutely, no rush! Thanks! Should I close the related issue for now, or keep both? |
Contributor
|
Hmm, I think I'll do the same thing I did for your other PR and close the PR in favor of discussion in the ticket. Consider it temporary, until a decision has been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
**Fixes flarum/issue-archive#226 **
Changes proposed in this pull request:
As of right now, the mobile header displays a back arrow at the top right corner on some pages (specifically discussion pages). This adds no actual value to the user:
In summary, this change makes it much more convenient for users to access their account info/other navbar items, removes a somewhat redundant element, and does not diminish aesthetic.
Reviewers should focus on:
If there's no logo, should we add a fontawesome home icon next to the forum title in the mobile navbar?
Screenshot
https://i.imgur.com/4MXvXQR.png
https://i.imgur.com/tdUw1vZ.png
Confirmed