Fixed Broken Badges in ReadMe.md #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Flarum Team, I just noticed that all the badges provided by Poser are broken because their website server is no more available. So, I updated all the broken badges in the ReadMe.md file with the badges provided by the shields.io website which is a reliable and my favorite tool for adding badges to Readme.md files. Badges updated: 1. Total Downloads 2. Latest Version 3. License Kindly review and merge my Pull Request. Thanks.
smartclash
approved these changes
Oct 4, 2020
dsevillamartin
requested changes
Oct 4, 2020
README.md
Outdated
| <a href="https://packagist.org/packages/flarum/core"><img src="https://poser.pugx.org/flarum/core/v/unstable.svg" alt="Latest Version"></a> | ||
| <a href="https://packagist.org/packages/flarum/core"><img src="https://poser.pugx.org/flarum/core/license.svg" alt="License"></a> | ||
| <a href="https://packagist.org/packages/flarum/core"><img src="https://img.shields.io/packagist/dt/flarum/core" alt="Total Downloads"></a> | ||
| <a href="https://packagist.org/packages/flarum/core"><img src="https://img.shields.io/packagist/v/flarum/core" alt="Latest Version"></a> |
There was a problem hiding this comment.
This shows v0.1.0-beta instead of v0.1.0-beta.13. I'm not sure if shields can show the latest beta correctly.
There was a problem hiding this comment.
might be better to just use the lastest github release instead of packagist
https://img.shields.io/github/v/release/flarum/core?include_prereleases&sort=semver
There was a problem hiding this comment.
@SychO9 I like that, and we can remove include_prereleases and it'll still work
https://img.shields.io/github/v/release/flarum/core?sort=semver
There was a problem hiding this comment.
Hi @datitisev and @SychO9,
I have updated it as per the changes requested. It is now showing a full version of the latest release. Kindly review.
As suggested, I have changed the packagist badge to the Github Releases badge. Now, it is showing the full version of the latest release. Kindly merge the PR.
dsevillamartin
approved these changes
Oct 4, 2020
askvortsov1
approved these changes
Oct 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Flarum Team,
I just noticed that all the badges provided by Poser are broken because their website server is no more available. So, I updated all the broken badges in the ReadMe.md file with the badges provided by the shields.io website which is a reliable and my favorite tool for adding badges to Readme.md files.
Badges updated:
Changes proposed in this pull request:
Updated Broken Badges in ReadMe.md file of flarum/core repository
Reviewers should focus on:
I have updated the ReadMe.md file kindly review it only.
Screenshot
Before:
After:
Kindly review and merge my Pull Request.
Thanks & Regards,
Abhishek Verma