Assorted Typing Fixes #3348
Assorted Typing Fixes #3348
Conversation
askvortsov1
requested review from
clarkwinkelmann,
dsevillamartin,
davwheat and
SychO9
The tsconfig changes from that command are ignored, since we don't yet support "replacable sections" that would let us add custom config.
There was a problem hiding this comment.
Amazing to see this!
Wouldn't have been fun across multiple repositories >.>
Looks like the diff shows dist files despite .gitattributes files instructing against, it seems like only a root level .gitattributes is taken into consideration so we'll probably want to add one.
Other than that, all looks good to me! Thanks for the well-split commits.
There was a problem hiding this comment.
Most of these are just using import type instead of import to make certain that we don't accidentally use the imports for anything except typing.
Another thing to note is that we should really be marking view method return types as Mithril.Children rather than the automatic JSX.Element since that doesn't allow extends/overrides to return things like null, strings, numbers or arrays as fragments.
Thank you for your hard work on this 🤗🥰
askvortsov1
force-pushed
the
as/typing-fixes
branch
from
c84060d
to
3ddec0a
Compare
Moving one step closer to having all the hundreds of CI jobs on this monorepo be green.