Skip to content

Conversation

@luceos
Copy link
Member

@luceos luceos commented Aug 5, 2022

Fixes #0000

Changes proposed in this pull request:

This PR supposedly adds two new values by default to each post whenever Likes is enabled. A count of likes and the most recent likes.

I ran into an issue with the count, but before I spend much more time on this let's figure out whether we want this at all.

(I know dist needs to be removed :) )

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

@luceos luceos changed the title Dk/likes/load only necessary likes [likes] reduce performance impact, add count and recent likes Aug 5, 2022
@clarkwinkelmann
Copy link
Member

I know it's still a work in progress, but just reading through the code I notice the isLiked part in addLikeAction is not updated with new code yet.

@luceos
Copy link
Member Author

luceos commented Aug 16, 2022

Yeah. We still need to decide whether we want this and if we do, finish it.

@SychO9 SychO9 added this to the 1.8 milestone Mar 17, 2023
@SychO9
Copy link
Member

SychO9 commented Apr 1, 2023

Superseded by #3781

@SychO9 SychO9 closed this Apr 1, 2023
@SychO9 SychO9 removed this from the 1.8 milestone Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants