Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: discussion UTF-8 slug driver #3606

Merged
merged 3 commits into from Aug 21, 2022
Merged

feat: discussion UTF-8 slug driver #3606

merged 3 commits into from Aug 21, 2022

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented Aug 21, 2022 •
edited

Revives #3386

Changes proposed in this pull request:

  • Adds a UTF-8 discussion slugger
  • Adds tests for all current sluggers

One thing I noticed is the slug attribute of the discussion model seems pretty useless, we should drop it at some point.

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

askvortsov1 and others added 3 commits August 21, 2022 11:10
@askvortsov1 @SychO9
feat: add utf-8 slug driver
551fa0e
@SychO9
test: add tests for slugging expectations
a40e780 
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9
fix: non-word characters aren't removed
fbf1a59 
Signed-off-by: Sami Mazouz <ilyasmazouz@gmail.com>
@SychO9 SychO9 self-assigned this Aug 21, 2022
@SychO9 SychO9 added this to the 1.5 milestone Aug 21, 2022
@SychO9 SychO9 merged commit f7dd609 into main Aug 21, 2022
@SychO9 SychO9 deleted the sm/discussion-utf8-slug-driver branch August 21, 2022 14:27
@luceos luceos mentioned this pull request Sep 8, 2022
Closed
@PipecraftNet PipecraftNet mentioned this pull request Oct 31, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davwheat davwheat davwheat approved these changes

Assignees

@SychO9 SychO9

Labels
type/feature
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SychO9 @davwheat @askvortsov1