-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: cli command for enabling or disabling an extension #3816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is neat! Thanks! some comments.
framework/core/src/Extension/Console/ToggleExtensionCommand.php
Outdated
Show resolved
Hide resolved
framework/core/src/Extension/Console/ToggleExtensionCommand.php
Outdated
Show resolved
Hide resolved
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we planning to eventually add some kind of "enable/disable all" to this, or would that (and bisection) be a separate command?
switch ($enabling) { | ||
case true: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like an if/else would suffice here? I don't see how we're going to get any more cases than that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly true, I've been using the php8 match
so often lately that my brain tries to produce something similar 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, pattern matching is indeed wonderful!
suspiciously drops https://ocaml.org/docs/data-types on the way out
The enabl/disable all could be eventually part of this same command I think, we'd probably use an The bisect should be its own command imo |
Changes proposed in this pull request:
Adds a new CLI command to enable toggling of a given extension.
Usage:
Reviewers should focus on:
Screenshot

Necessity
Confirmed
composer test
).Required changes: