Repository navigation
feat: cli command for enabling or disabling an extension - #3816
Conversation
SychO9
left a comment
There was a problem hiding this comment.
This is neat! Thanks! some comments.
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
Co-authored-by: Sami Mazouz <sychocouldy@gmail.com>
askvortsov1
left a comment
There was a problem hiding this comment.
Are we planning to eventually add some kind of "enable/disable all" to this, or would that (and bisection) be a separate command?
| switch ($enabling) { | ||
| case true: |
There was a problem hiding this comment.
I feel like an if/else would suffice here? I don't see how we're going to get any more cases than that.
There was a problem hiding this comment.
honestly true, I've been using the php8 match so often lately that my brain tries to produce something similar 😆
There was a problem hiding this comment.
Ah yes, pattern matching is indeed wonderful!
suspiciously drops https://ocaml.org/docs/data-types on the way out
The enabl/disable all could be eventually part of this same command I think, we'd probably use an The bisect should be its own command imo |
Changes proposed in this pull request:
Adds a new CLI command to enable toggling of a given extension.
Usage:
Reviewers should focus on:
Screenshot

Necessity
Confirmed
composer test).Required changes: