Skip to content

chore: update codebase to php8.1 #3827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
May 30, 2023
Merged

chore: update codebase to php8.1 #3827

merged 16 commits into from
May 30, 2023

Conversation

SychO9
Copy link
Member

@SychO9 SychO9 commented May 25, 2023

Changes proposed in this pull request:

  • Updates minimum version to php 8.1
  • Updates typings throughout the codebase
  • Updates the code to use some new php features such as the constructor property promotion or str_contains.

QA

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)
  • Related core extension PRs: (Remove if irrelevant)

SychO9 and others added 15 commits May 24, 2023 09:21
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 marked this pull request as ready for review May 27, 2023 14:05
@SychO9 SychO9 requested a review from a team as a code owner May 27, 2023 14:05
@SychO9 SychO9 added this to the 2.0 milestone May 27, 2023
@SychO9 SychO9 requested a review from imorland May 27, 2023 14:05
Signed-off-by: Sami Mazouz <sychocouldy@gmail.com>
@SychO9 SychO9 changed the base branch from main to 2.x May 30, 2023 09:09
@imorland imorland merged commit 6f11e04 into 2.x May 30, 2023
@imorland imorland deleted the sm/php8.1-phpstan-upgrades branch May 30, 2023 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants