fix: Removed mentions specific spoiler code#14
Conversation
Removed mentions specific less code, also fixed links and code in spoiler.
|
Updated the LESS to be far more universal, fixing all images, links, text, mentions, etc. Also makes it easier to add more as we find issues. |
The block spoiler works fine without fixes, global spoiler class causes issues.
| padding: 0; | ||
| color: transparent; | ||
| cursor: default; | ||
| } |
There was a problem hiding this comment.
Could we turn the styling for links into this?
* {
color: transparent;
background: transparent;
pointer-events: none;
}Would that still work? That would be super generic. 😁
There was a problem hiding this comment.
It's also curious that the old code had an explicit background for the link (line 10), but your new proposal does not.
|
Can you expand on why it works without changes for the block spoiler? |
|
The block spoiler is rendered as a details tag, what this means is that at no time is the content actually "shown" until the user clicks on it. Essentially it's like a drop down menu, the contents of said menu aren't visible at all (not even under something) until you click on it. Thus you can put anything you want inside the block spoiler and it won't be shown until you click the "details" drop down button. We could do a little work on the details header/button if we wanted for styling purposes but it does not affect the actual functionality. |
Also fixed links, code and images in spoiler, and hopefully all other children. The block spoiler works fine without fixes, global spoiler class causes issues.
Also fixed links, code and images in spoiler, and hopefully all other children. The block spoiler works fine without fixes, global spoiler class causes issues.
2 participants
Fixes: flarum/framework#2053
Removed mentions specific less code, also fixed links and code in spoiler.
Before Clicking:
After Clicking:
