New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix evaluation of post content by m.trust() #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good and tested locally.
Should we add a comment maybe? Like
// Wrapping in <div> because ItemList entries need to be vnodes
Something else I thought of is that we can also use a text vnode. Unfortunately Mithril has no helper method to generate them, so that instantly makes the code less readable https://mithril.js.org/vnodes.html#vnode-types
This is how it would work if we wanted to use a text vnode. I tested it locally:
items.add('excerpt', {tag: "#", children: excerpt}, -100);
EDIT: also probably not an issue, but was this branched out of an older version? The fix from 55cc45c isn't present when I checkout this PR. Should fix itself by merging anyway.
|
I don't have a strong opinion on using a text vnode or wrapping in
Ah yes, I seem to have forgotten to update my local master branch. Won't be a problem for git though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally again, all good for me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested locally. confirmed to resolve the issue
|
@SychO9 please provide a reason for a PR when creating one, that makes writing changelogs a ton easier ;) |
No description provided.