Skip to content

Fixed restricted tags having enabled "Start Discussion" button#74

Merged
franzliedke merged 2 commits into
flarum:masterfrom
askvortsov1:as/fix_start_discussion_button_enabled_on_restricted_tags
Apr 24, 2020
Merged

Fixed restricted tags having enabled "Start Discussion" button#74
franzliedke merged 2 commits into
flarum:masterfrom
askvortsov1:as/fix_start_discussion_button_enabled_on_restricted_tags

Conversation

@askvortsov1

Copy link
Copy Markdown
Contributor

Comment thread js/src/forum/addTagFilter.js

@franzliedke franzliedke left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish the original sidebarItems method would receive the "forum" (i.e. the container for discussions) as a parameter instead of accessing the global. Then we could pass in a slightly different object and could rely on core's behavior in terms of styling and labeling.

But for now, this is great. Thanks for tackling it!

@NamVr

NamVr commented Jul 9, 2020

Copy link
Copy Markdown

Hey is there any way that I can restrict the use of tags for normal members? Like I made a tag of News and Announcements where I don't want people to make new discussions, I simply want it to be read-only.

@PeopleInside

Copy link
Copy Markdown

Hi @allroundernaman, this should be done on the permission page where you can add a label and give the desired permission.
For questions like this you can use the Flarum community https://discuss.flarum.org/

@NamVr

NamVr commented Jul 17, 2020

Copy link
Copy Markdown

Thanks I got that.
Regards,

@PeopleInside

Copy link
Copy Markdown

I'm happy to read you found it.
Actually you can be interested in this topic: https://discuss.flarum.org/d/24431-cannot-add-label-permission-beta-13

@NamVr

NamVr commented Jul 17, 2020 via email

Copy link
Copy Markdown

askvortsov1 added a commit that referenced this pull request Mar 11, 2022
Also, change the label when the button is disabled.
askvortsov1 added a commit that referenced this pull request May 10, 2022
Also, change the label when the button is disabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restricted tag issue

5 participants