Improve dockerfile #210
Merged
Improve dockerfile #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukevs
reviewed
Jan 3, 2022
Dockerfile
Outdated
| # easter eggs 😝 | ||
| RUN echo "PS1='🕵️:\[\033[1;36m\]\h \[\033[1;34m\]\W\[\033[0;35m\]\[\033[1;36m\]$ \[\033[0m\]'" >> ~/.bashrc | ||
| # easter eggs | ||
| RUN echo "PS1='️ :\[\033[1;36m\]\h \[\033[1;34m\]\W\[\033[0;35m\]\[\033[1;36m\]$ \[\033[0m\]'" >> ~/.bashrc |
|
Did some tests locally and all looks good! Only comment is those emojis :) Then good to go! |
|
Merged - thanks @tmikulin !! |
|
np @lukevs |
mendesfabio
pushed a commit
to mendesfabio/mev-inspect-py
that referenced
this pull request
Nov 21, 2022
Improve dockerfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) Changed the parent docker image to buster slim (still debian based but a lot more slimmer)
2.) Added a separate flashbot user (for security), it doesn't run as the root user.
3.) Also worth mentioning, since the container now runs as a non root user you won't be able to install any stuff in the image.
The resulting docker image is half the size of the original one, which will come in handy with the CI/CD stuff.
I'm not sure how you handle the CI/CD part, I didn't find any build info (I guess for now you use git pull or something like that)
Tom