test: Checkpoint #54
Merged
test: Checkpoint #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karim-agha
approved these changes
Nov 7, 2025
| /// Helper test function to apply multiple transactions on a checkpoint | ||
| fn apply_multiple<P: PlatformWithRpcTypes>( | ||
| root: Checkpoint<P>, | ||
| txs: &[Recovered<types::Transaction<P>>], |
Collaborator
There was a problem hiding this comment.
Maybe txs: impl Iterator<Item=types::Transaction<P>>>?
Collaborator
There was a problem hiding this comment.
also, this can be written as something along those lines:
let c1 = block.start();
let many_txs = vec![100 txs];
let c100 = many_txs.into_iter().fold(c1, Checkpoint::apply)
Collaborator
There was a problem hiding this comment.
nit: also maybe apply_many, or we can make apply itself work with individual or collections of txs.
Collaborator
There was a problem hiding this comment.
sorry, was thinking that this is at the Checkpoint type, not in a test helper. Forget everything I said ;-)
Collaborator
Author
There was a problem hiding this comment.
Yep I'm not sure if it's a good idea to add a apply_many at the checkpoint type level but we can discuss this separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified checkpoint's tests to improve overall coverage.
One thing is I modified the mocked StateRootProvider for GenesisStateProvider to provide empty state root (instead of random state root), to ensure predictability in tests (for example comparing two payloads built out of the same checkpoint, so they should be equal)