-
Notifications
You must be signed in to change notification settings - Fork 16
chore: add tests to executable #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds unit tests for the payload execution module (src/payload/exec.rs) and introduces test utility functions for creating reverting and invalid transactions. The changes support testing the Executable enum and its execution methods.
- Adds 23 unit tests covering
Executable,ExecutionResult, andIntoExecutabletrait implementations - Introduces
reverting_txandinvalid_txhelper functions in test utilities - Tests cover transaction execution, bundle execution, and various conversion methods
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/test_utils/transactions.rs | Adds reverting_tx and invalid_tx helper functions for creating test transactions with specific failure behaviors |
| src/payload/exec.rs | Adds comprehensive test suite with 23 tests covering execution of transactions, bundles, and various conversion paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
a977847 to
8473cdc
Compare
|
thanks for the feeback @julio4, looking forward to keep contributing to flashbots :) |
unit tests for the payload execution module
Closes #29