feat: combinator step Chain #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julio4
force-pushed
the
feat/combinator-all
branch
from
71e983e to
197bcdf
Compare
karim-agha
approved these changes
Nov 12, 2025
Collaborator
karim-agha
left a comment
karim-agha
left a comment
There was a problem hiding this comment.
Nit: wondering if the name All won't make people assume that it behaves like Atomic. Maybe Chain gives less promises about the behavior? Just thinking out loud.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The All combinator step should be exactly the same as just applying a sequence of step, i.e.:
all!(StepA, StepB, StepC) == .with_step(StepA).with_step(StepB).with_step(StepC)