Implement cached reads #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karim-agha
approved these changes
Nov 20, 2025
src/payload/ext/cached_state.rs
Outdated
| cache.insert_storage(key, Some(value)); | ||
| } | ||
| }); | ||
| println!( |
Collaborator
There was a problem hiding this comment.
Suggested change
| println!( | |
| info!( |
Collaborator
There was a problem hiding this comment.
to make it work with TEST_TRACE=on test logging
dvush
approved these changes
Nov 20, 2025
julio4
approved these changes
Nov 20, 2025
src/payload/ext/cached_state.rs
Outdated
| /// # Example | ||
| /// | ||
| /// ``` | ||
| /// use reth_revm::{cached::CachedReads, DatabaseRef, db::State}; |
src/payload/ext/cached_state.rs
Outdated
Comment on lines
524
to
560
| #[test] | ||
| fn measure_storage_cache_overhead() { | ||
| let (base_overhead, cache) = | ||
| measure_allocation(|| AccountStorageCache::new()); | ||
| info!("Base AccountStorageCache overhead: {base_overhead} bytes"); | ||
| let mut rng = rand::rng(); | ||
|
|
||
| let key = StorageKey::random(); | ||
| let value = StorageValue::from(rng.random::<u128>()); | ||
| let (first_slot, _) = measure_allocation(|| { | ||
| cache.insert_storage(key, Some(value)); | ||
| }); | ||
| info!("First slot insertion overhead: {first_slot} bytes"); | ||
|
|
||
| const TOTAL_SLOTS: usize = 10_000; | ||
| let (test_slots, _) = measure_allocation(|| { | ||
| for _ in 0..TOTAL_SLOTS { | ||
| let key = StorageKey::random(); | ||
| let value = StorageValue::from(rng.random::<u128>()); | ||
| cache.insert_storage(key, Some(value)); | ||
| } | ||
| }); | ||
| info!( | ||
| "Average overhead over {} slots: {} bytes", | ||
| TOTAL_SLOTS, | ||
| test_slots / TOTAL_SLOTS | ||
| ); | ||
|
|
||
| info!("\nTheoretical sizes:"); | ||
| info!("StorageKey size: {} bytes", size_of::<StorageKey>()); | ||
| info!("StorageValue size: {} bytes", size_of::<StorageValue>()); | ||
| info!( | ||
| "Option<StorageValue> size: {} bytes", | ||
| size_of::<Option<StorageValue>>() | ||
| ); | ||
| info!("Option<B256> size: {} bytes", size_of::<Option<B256>>()); | ||
| } |
Collaborator
There was a problem hiding this comment.
Should we keep this as test?
src/payload/block.rs
Outdated
Comment on lines
84
to
85
| // TODO: Prefill execution_cached with bundle state from the previous block | ||
| let execution_cached = ExecutionCache::default(); |
Collaborator
There was a problem hiding this comment.
We can add a cache: Option<ExecutionCache> as argument.
And we can handle passing cache across blocks at the pipeline level
julio4
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement layer of caching for state, prefilled with previous block bundle state.
Probably we don't need DashMap and could use HashMap, would be refactored later, once we see more concrete usage examples