From e062999903d88181f4e97e2ff85fb1837e85538a Mon Sep 17 00:00:00 2001 From: Daniel Xifra Date: Tue, 4 Nov 2025 16:40:47 -0300 Subject: [PATCH 1/2] proper non_mempool_coinbase_profit on DelayedRefunds --- crates/rbuilder/src/building/mod.rs | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/crates/rbuilder/src/building/mod.rs b/crates/rbuilder/src/building/mod.rs index 7947b9b0e..2b70890cd 100644 --- a/crates/rbuilder/src/building/mod.rs +++ b/crates/rbuilder/src/building/mod.rs @@ -1301,17 +1301,18 @@ pub fn create_sim_value( // We don't filter for mempool txs. order_ok.coinbase_profit } else { - let non_mempool_coinbase_profit = order_ok + let mempool_coinbase_profit = order_ok .tx_infos .iter() - .filter(|tx_info| !mempool_detector.is_mempool(&tx_info.tx)) + .filter(|tx_info| mempool_detector.is_mempool(&tx_info.tx)) .map(|tx_info| tx_info.coinbase_profit) .sum::(); - if non_mempool_coinbase_profit.is_zero() || non_mempool_coinbase_profit.is_positive() { - non_mempool_coinbase_profit.unsigned_abs() + if mempool_coinbase_profit.is_positive() { + order_ok + .coinbase_profit + .saturating_sub(mempool_coinbase_profit.unsigned_abs()) } else { - // This could be a bundle which was positive thanks to the inclusion of mempool txs. - U256::ZERO + order_ok.coinbase_profit } }; From b436babe4e6567267678c381250ca7aa068bc602 Mon Sep 17 00:00:00 2001 From: Daniel Xifra Date: Tue, 4 Nov 2025 17:25:56 -0300 Subject: [PATCH 2/2] fixed test --- crates/rbuilder/src/building/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/crates/rbuilder/src/building/mod.rs b/crates/rbuilder/src/building/mod.rs index 2b70890cd..ba74d5a45 100644 --- a/crates/rbuilder/src/building/mod.rs +++ b/crates/rbuilder/src/building/mod.rs @@ -1346,7 +1346,7 @@ mod test { let profit_1 = I256::unchecked_from(1000); let profit_2 = I256::unchecked_from(10000); let order_ok = OrderOk { - coinbase_profit: Default::default(), + coinbase_profit: (profit_1 + profit_2).unsigned_abs(), space_used: Default::default(), cumulative_space_used: Default::default(), tx_infos: vec![