Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Fixes for Song Preview and Editor #214

Merged
merged 9 commits into from Aug 30, 2020
Merged

Conversation

Psycast
Copy link
Member

@Psycast Psycast commented Aug 28, 2020

Changes:

  • Make user avatar loading a callable function so replays and previews can load just the avatar.
  • Redo song previews to use the AutoPlay bot.

Fixes:

  • Make Song Preview and Menu Music context menu items use a new GameOptions each time to prevent a crash.
  • Fixes a softlock where opening the editor, then playing a song preview, would get the game stuck in both a editor and replay mode that would freeze when clicking Close.
  • Fixes song previews not working for alt engines.

Also make chart preview use a new GameOptions each time.
@Psycast Psycast requested a review from a team as a code owner August 28, 2020 21:03
Due to possible missing _gvars.options when the song is loaded in the background.
- Adds support for previewing Alt Engine songs.
- Fixes Previews on songs that have incorrect or missing note count in the playlist.
- Fixes small UI issues on the results screen where it was displaying as replay instead of preview.
@Psycast Psycast changed the title Clear Editor Flag when leaving Editor Multiple Fixes for Song Preview and Editor Aug 28, 2020
@Psycast Psycast merged commit a4cecc1 into main Aug 30, 2020
@Psycast Psycast deleted the fix/editor-and-song-preview branch August 30, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants