Add freebsd_spi programmer

[valpackett]

Based on linux_spi, using FreeBSD's spigen(4) interface

[emaste]

Is there anything holding up this change?

[dhendrix]

It looks pretty good overall. My only issue is the use of alloca(), and that's easy to fix.

I also went ahead and posted this on the upstream review server: https://review.coreboot.org/c/flashrom/+/30764.

[dhendrix]

Please use malloc() instead (see the BUGS section of https://www.freebsd.org/cgi/man.cgi?alloca).

[felixsinger]

@unrelentingtech Hi there. Thank you for your patch! Very cool.

Could you rebase this and push it to review.coreboot.org? That would be great!

[valpackett]

No, sorry, I'm not interested anymore.

[n-huber]

Hi Greg, sorry that this was lost in 2019. Not sure if you received emails from our Gerrit instance. There was some concern about your Signed-off-by. Is "Greg V" your full name? If not, I think either " " or "Greg V" with a complete email address would suffice. This would help us to get the code merged without taking any risk.
Also, if possible GPLv2+, i.e. "version 2 or later", would be preferred. If you take the time to push an updated commit, that would be very nice. We could take it from there and update and merge the code.

[valpackett]

• I'm in the process of deprecating that name and I do not publicly have a "real" or "full" sounding name right now;
• I hate harmful "real name" policies, anything resembling those makes me disinterested very quickly;
• As I said, I'm not interested in this actual work anymore, I don't currently have the means to update and test the patch. I closed this for a reason;
• Anyone is free to take the patch, assign copyright to themselves, relicense to whatever license, rebase/update, etc. Basically all my contributions like that are intended to be available under maximally permissive terms like 0BSD.

[n-huber]

Thanks! your written permission here is good enough for me. And I'm very sorry about one point of confusion: I didn't realize that technology is a TLD by now ._.

[emaste]

@n-huber will you make the malloc change and merge then?

[felixsinger]

The patch needs to be rebased first. In the meantime things might have changed a little.

And also, we had a discussion about it in IRC. We are thinking if we could add an abstraction layer to minimize the code for freebsd_spi, linux_spi and maybe others.

But in general, we want to have this :)