Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ERROR_404_HELP = False by default #545

Closed
wswld opened this issue Dec 4, 2015 · 3 comments
Closed

Make ERROR_404_HELP = False by default #545

wswld opened this issue Dec 4, 2015 · 3 comments

Comments

@wswld
Copy link
Contributor

@wswld wswld commented Dec 4, 2015

I encountered an issue with ERROR_404_HELP occassionally and found it to be extremely counterintuitive (that one code behaved completely differently than the others) and underdocumented. My suggestion is to make it:

help_on_404 = current_app.config.get("ERROR_404_HELP", False)

I can provide a pull request if required.

@wswld wswld changed the title Make ERROR_404_HELP = False by default Make `ERROR_404_HELP` = False by default Dec 4, 2015
@wswld wswld changed the title Make `ERROR_404_HELP` = False by default Make ERROR_404_HELP = False by default Dec 4, 2015
@mrkmcknz
Copy link

@mrkmcknz mrkmcknz commented Jan 20, 2016

I second this.

@joshfriend
Copy link
Member

@joshfriend joshfriend commented Feb 27, 2016

I always turn this off too as I don't find it helpful. I'd rather remove it completely TBH.

wswld added a commit to wswld/flask-restful that referenced this issue Oct 29, 2016
wswld added a commit to wswld/flask-restful that referenced this issue Oct 29, 2016
@wswld
Copy link
Contributor Author

@wswld wswld commented Oct 29, 2016

Provided a pull-request. Please check it out.

wswld added a commit to wswld/flask-restful that referenced this issue Jun 6, 2018
@joshfriend joshfriend closed this in f9790d2 Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.