New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ERROR_404_HELP = False by default #545

Closed
wswld opened this Issue Dec 4, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@wswld
Contributor

wswld commented Dec 4, 2015

I encountered an issue with ERROR_404_HELP occassionally and found it to be extremely counterintuitive (that one code behaved completely differently than the others) and underdocumented. My suggestion is to make it:

help_on_404 = current_app.config.get("ERROR_404_HELP", False)

I can provide a pull request if required.

@wswld wswld changed the title from Make ERROR_404_HELP = False by default to Make `ERROR_404_HELP` = False by default Dec 4, 2015

@wswld wswld changed the title from Make `ERROR_404_HELP` = False by default to Make ERROR_404_HELP = False by default Dec 4, 2015

@mrkmcknz

This comment has been minimized.

Show comment
Hide comment
@mrkmcknz

mrkmcknz Jan 20, 2016

I second this.

I second this.

@joshfriend

This comment has been minimized.

Show comment
Hide comment
@joshfriend

joshfriend Feb 27, 2016

Member

I always turn this off too as I don't find it helpful. I'd rather remove it completely TBH.

Member

joshfriend commented Feb 27, 2016

I always turn this off too as I don't find it helpful. I'd rather remove it completely TBH.

wswld added a commit to wswld/flask-restful that referenced this issue Oct 29, 2016

wswld added a commit to wswld/flask-restful that referenced this issue Oct 29, 2016

@wswld

This comment has been minimized.

Show comment
Hide comment
@wswld

wswld Oct 29, 2016

Contributor

Provided a pull-request. Please check it out.

Contributor

wswld commented Oct 29, 2016

Provided a pull-request. Please check it out.

wswld added a commit to wswld/flask-restful that referenced this issue Jun 6, 2018

@joshfriend joshfriend closed this in f9790d2 Jun 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment