This repository has been archived by the owner on May 30, 2023. It is now read-only.
switch docker pkgs to go1.16 #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now build with go1.16 and the go1.16 tag does not show up anywhere in the cli repo. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Upstream builds with go1.16 too. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Upstream builds go through github.com/docker/docker repo and that builds with go1.16 with module support disabled. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Upstream builds with go1.16. Additionally fixup the VERSION variable specify the current Flatcar Docker version 20.10. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
These are no longer used by anything in the tree, after removing old versions of docker-runc/docker-proxy/containerd. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
|
CI passed except for |
|
@jepio I restarted the tests only for |
tormath1
reviewed
Aug 25, 2021
|
Bump? |
|
The reason for keeping go 1.13 was #774. Not sure what to do. Maybe make sure that the issue with SIGURG got fixed in docker/containerd/whatever else? |
|
The problem is addressed as far as I know and upstream switched to 1.16 - we ran into it because we tried to switch earlier than upstream. I also remember some Go changes which further reduced the signals being delivered where they weren't expected - but don't have a link now. |
pothos
approved these changes
Aug 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch docker pkgs to go1.16
Docker upstream started building with go1.16, so we should do the same. If we also get rid of old versions of
container/docker-runc/docker-proxy ebuilds, we can remove go1.13 and go1.7 from the tree.
How to use
Testing done
CI running: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3369/