This repository has been archived by the owner on May 30, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
app-crypt/trousers: Skip tscd.service for TPM2 devices #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Oct 21, 2021
@@ -4,6 +4,7 @@ ConditionPathExists=/dev/tpm0 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
ConditionSecurity=!tpm2 |
This could be used in [Unit]
instead of ExecCondition
under [Service]
, as suggested in flatcar/Flatcar#208 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yet, only for Alpha, and for Stable/Beta we should pick the change as it is here. Maybe the above suggestion is better for a follow-up PR only for Alpha.
trousers supports TPM 1.2, and fails for TPM 2. This commits skips the tcsd service if TPM 2 is detected. Signed-off-by: Sayan Chowdhury <schowdhury@microsoft.com>
sayanchowdhury
force-pushed
the
sayan/skip-tcsd-for-tpm2
branch
from
October 22, 2021 06:58
d7b2ee1
to
b521a07
Compare
CI Passed
|
pothos
approved these changes
Oct 22, 2021
sayanchowdhury
added a commit
that referenced
this pull request
Oct 22, 2021
app-crypt/trousers: Skip tscd.service for TPM2 devices
sayanchowdhury
added a commit
that referenced
this pull request
Oct 22, 2021
app-crypt/trousers: Skip tscd.service for TPM2 devices
sayanchowdhury
added a commit
that referenced
this pull request
Oct 22, 2021
app-crypt/trousers: Skip tscd.service for TPM2 devices
sayanchowdhury
added a commit
that referenced
this pull request
Oct 22, 2021
app-crypt/trousers: Skip tscd.service for TPM2 devices
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trousers supports TPM 1.2, and fails for TPM 2. This commits
skips the tcsd service if TPM 2 is detected.
Fixes flatcar/Flatcar#208
Signed-off-by: Sayan Chowdhury schowdhury@microsoft.com
Testing done
CI Running http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3911/cldsv/