Skip to content
This repository has been archived by the owner on May 30, 2023. It is now read-only.

app-arch/torcx: Fix wrong reference to Docker 19.03 #1456

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

pothos
Copy link
Contributor

@pothos pothos commented Dec 1, 2021

When selecting the docker-1.12-no profile, torcx failed because the
profile looked for 19.03 instead of 20.10.

Make the docker-1.12-no profile identical to the vendor profile so
that we don't have to update it.

How to use

Check that

echo docker-1.12-no | sudo tee /etc/torcx/next-profile
sudo reboot

works again.

Backport to Stable, Beta, Alpha.

Testing done

build scheduled, ran the above test

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@pothos pothos requested a review from a team December 1, 2021 16:33
Copy link
Contributor

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the role of the docker-1.12 profile anyway?

@pothos
Copy link
Contributor Author

pothos commented Dec 1, 2021

What's the role of the docker-1.12 profile anyway?

Torcx knows about the file /etc/flatcar/docker-1.12 which can have yes or no and I think /etc/torcx/next-profile can also have docker-1.12-yes or docker-1.12-no 🤷

When selecting the docker-1.12-no profile, torcx failed because the
profile looked for 19.03 instead of 20.10.

Make the docker-1.12-no profile identical to the vendor profile so
that we don't have to update it.
@pothos pothos merged commit 89a142f into main Dec 2, 2021
@pothos pothos deleted the kai/torcx-no-docker-1.12 branch December 2, 2021 10:45
pothos added a commit that referenced this pull request Dec 2, 2021
app-arch/torcx: Fix wrong reference to Docker 19.03
pothos added a commit that referenced this pull request Dec 2, 2021
app-arch/torcx: Fix wrong reference to Docker 19.03
pothos added a commit that referenced this pull request Dec 2, 2021
app-arch/torcx: Fix wrong reference to Docker 19.03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants