Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

coreos-base/oem-ec2-compat: set correct console on arm64 #1628

Merged
merged 2 commits into from
Feb 11, 2022

Conversation

jepio
Copy link
Contributor

@jepio jepio commented Feb 9, 2022

coreos-base/oem-ec2-compat: set correct console on arm64

The default console (console=ttyAMA0) that is set by grub is wrong for EC2 arm64, set it to console=ttyS0 manually to allow capturing console output. With the wrong setting the kola console log is empty.

How to use

Start an arm64 EC2 instance.

Testing done

CI passed and more data is found in console.txt (http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/4797/cldsv/)

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)

@jepio jepio force-pushed the jepio/aws-arm64-fix-console branch from 0e1e3f8 to 12192dc Compare February 9, 2022 16:26
The default arm64 console (console=ttyAMA0) that is set by grub is wrong for
EC2 arm64, so fix the value and enable earlycon.
@jepio jepio force-pushed the jepio/aws-arm64-fix-console branch from 12192dc to d7b6064 Compare February 9, 2022 16:26
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
@jepio jepio marked this pull request as ready for review February 10, 2022 12:31
@jepio jepio changed the title coreos-base/oem-ec2-compat: prevent console from being set on arm64 coreos-base/oem-ec2-compat: set correct console on arm64 Feb 10, 2022
@krnowak
Copy link
Contributor

krnowak commented Feb 11, 2022

The console.txt contents seem to be truncated to about last 80kb of logs. But this is probably outside the scope of this PR, right?

@jepio
Copy link
Contributor Author

jepio commented Feb 11, 2022

EC2 buffers the last 64kB, we fetch the console twice before the test ends. It would need an asynchronous console-fetcher in kola to overcome this limitation, so yeah, out of scope.

@krnowak
Copy link
Contributor

krnowak commented Feb 11, 2022

Welp, still better than no file at all. Care to file an issue on mantle about this? Thanks.

@jepio
Copy link
Contributor Author

jepio commented Feb 11, 2022

New issue here flatcar/Flatcar#625

@jepio jepio merged commit 6ba4e6c into main Feb 11, 2022
@jepio jepio deleted the jepio/aws-arm64-fix-console branch February 11, 2022 14:44
pothos added a commit that referenced this pull request Apr 28, 2022
coreos-base/oem-ec2-compat: set correct console on arm64
@pothos
Copy link
Contributor

pothos commented Apr 28, 2022

Picked for flatcar-3033 and flatcar-3139

pothos added a commit that referenced this pull request Apr 28, 2022
coreos-base/oem-ec2-compat: set correct console on arm64
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants