-
Notifications
You must be signed in to change notification settings - Fork 36
bump coreos-init and bootengine commit for cgroupv1-runtime-revert support #1666
Conversation
Test |
Out of curiosity is Flatcar now using cgroups v2 by default? |
Yes, for new installations, details here: https://www.flatcar.org/docs/latest/container-runtimes/switching-to-unified-cgroups/ |
…ange This pulls in flatcar/bootengine#35 and flatcar/init#62, which enable boot time switching back to legacy cgroups by creating a flag files (/etc/flatcar-cgroupv1) from ignition.
1c4d76e
to
d22fb6b
Compare
I'll merge this, ok @pothos? |
A changelog entry would be good when this PR gets cherry-picked it will also be taken |
Added the changelog entry. |
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
7369284
to
0a25892
Compare
bump coreos-init and bootengine commit for cgroupv1-runtime-revert support
bump coreos-init and bootengine commit for cgroupv1-runtime-revert support
This pulls in the changes to bootengine and coreos-init to enable runtime switching to cgroupv1. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
have you guys thought of the long term effects of this, because we are now introducing two ways of updating the kernel command line, one via initramfs and the other old and proven method via bootloader. People are going to wonder where these kernel options came from in the future. |
Yes, that is a concern we had when going down this road. We do prefer the proven bootloader method, but we heard from many users that they:
Did this change cause issues for you? Do you have any suggestions of how better to deal with this and the tradeoffs? |
This is only meant for the first boot. The correct kernel parameters should still be set the old way for persistence. |
@jepio Should we add logic to skip the bind-mounting if the parameters are already present? |
Or is this already done through the |
Yes (it is skipped if cgroupv2 is not mounted via the cgroup.subtree_control check) |
bump coreos-init and bootengine commit for cgroupv1-runtime-revert support
This introduces changes to bootengine and coreos-init to support dynamically switching back to legacy cgroups when the
/etc/flatcar-cgroupv1
flag file is found. This is done by running a binary before sysroot init is started by the initramfs, right after switch-root. This binary unmounts any cgroups initramfs may have set up and overlays /proc/cmdline with the right kernel arguments to convince systemd to setup legacy cgroups.Pulls in:
How to use
Build image and boot with the following ignition:
Testing done
Mantle test: flatcar/mantle#298.
CI started with newly added mantle test: http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/4935/cldsv/
changelog/
directory (user-facing change, bug fix, security fix, update)