This repository has been archived by the owner on May 30, 2023. It is now read-only.
add default kubernetes configuration #1944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongsupark
approved these changes
Jun 16, 2022
this pulls kubernetes module configuration. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
`docker.service` has a dependency to `containerd.service`: ``` $ systemctl list-dependencies docker.service docker.service containerd.service ... ``` If `docker.service` is not started (explicitly or via socket activation) `containerd.service` won't start. To ensure a seamless transition to kubernetes-1.24 let's enable by default `containerd.service`. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This is now handled in `flatcar-linux/init` repo in the `modules-load.d` config directory. Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
added a commit
to flatcar/mantle
that referenced
this pull request
Jun 17, 2022
this requires some changes introduced in: flatcar-archive/coreos-overlay#1944 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
added a commit
to flatcar/mantle
that referenced
this pull request
Jun 23, 2022
this requires some changes introduced in: flatcar-archive/coreos-overlay#1944 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
added a commit
to flatcar/mantle
that referenced
this pull request
Jun 23, 2022
this requires some changes introduced in: flatcar-archive/coreos-overlay#1944 Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
|
Should we backport this to all channels including LTS? I anyway have to do an |
|
@pothos this change should be harmless I'm fine with backporting it. |
pothos
added a commit
that referenced
this pull request
Jun 30, 2022
add default kubernetes configuration
|
Doing it now for 3227, 3139, 3033 because it is required for K8s 1.24 to work as expected |
pothos
added a commit
that referenced
this pull request
Jun 30, 2022
add default kubernetes configuration
pothos
added a commit
that referenced
this pull request
Jun 30, 2022
add default kubernetes configuration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on kubernetes-1.24 test in flatcar/mantle#337, we found that
containerdand some modules need to be enabled for satisfyingkubeadmpre-flight checks with the removal of Dockershim.This is also mentioned in the documentation: https://kubernetes.io/docs/setup/production-environment/container-runtimes/#forwarding-ipv4-and-letting-iptables-see-bridged-traffic
Initially
br_netfilterwas loaded by Docker directly.changelog/directory (user-facing change, bug fix, security fix, update)Note for reviewers
I'm not sure about backporting this change across the channels as we have workaround (enabling
containerd+ loading required modules with kernel arguments for example) - but maybe it's worth to call it out in the next release notes.