This repository has been archived by the owner on May 30, 2023. It is now read-only.
sys-kernel/coreos-module: use strip-debug instead of strip-unneeded #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With `--strip-unneeded` some static symbols are also stripped from modules, making stacktraces incomplete, and making it harder to debug kernel issues. Switch to the default setting of `--strip-debug`, which keeps symbols intact and does not appear to lead to a measurable size increase of the /usr partition.
Maybe it's good to include one here for future reference about which release includes this change |
|
Is there any size difference on |
|
Will add the changelog, and check the size difference on boot. I understand that we're close to the limit. This only affects modules, so the effect would be through the modules embed within the initramfs. Modules themselves are xz compressed. |
|
So from http://jenkins.infra.kinvolk.io:8080/job/container/job/image_changes/212/console and http://jenkins.infra.kinvolk.io:8080/job/container/job/image_changes/203/console:
on the arm64 side the boot partition size increase is not visible. |
|
Good, for arm64 there was no raise reported (Boot: 58 MiB) |
jepio
force-pushed
the
jepio-fix-kernel-stacktrace
branch
from
24a9eb3
to
af89197
Compare
pothos
reviewed
Sep 30, 2022
pothos
approved these changes
Sep 30, 2022
jepio
force-pushed
the
jepio-fix-kernel-stacktrace
branch
from
af89197
to
f0e7caa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys-kernel/coreos-module: use strip-debug instead of strip-unneeded
With
--strip-unneededsome static symbols are also stripped from modules, making stacktraces incomplete, and making it harder to debug kernel issues. Switch to the default setting of--strip-debug, which keeps symbols intact and does not appear to lead to a measurable size increase of the /usr partition.How to use
emerge-amd64-usr coreos-modules coreos-kernelTesting done
Booted image and checked:
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.